search

anvilproject / anvil-docker

Docker containers for Anvil Project
MIT License
7 stars 9 forks source link

IA-2279: set secure cookies so latest rocker versions work within iframes #18

Closed rtitle closed 4 years ago

rtitle commented 4 years ago

Hey @nturaga -- I think this setting will allow Terra to launch RStudio based on rocker/tidyverse:4.0.2. I tested with the images in this branch: https://github.com/anvilproject/anvil-docker/compare/update_R_4.0.2

Basically I think some cookies were getting rejected when RStudio was run within an iframe -- auth-cookies-force-secure=1 seems to resolve it.

See https://broadworkbench.atlassian.net/browse/IA-2279

nturaga commented 4 years ago

This is great! Thanks @rtitle . I'll give it a test run and get back to you.

rtitle commented 4 years ago

I take it the change works @nturaga? I can push the updated image versions (from this PR) to GCR if so.

nturaga commented 4 years ago

@rtitle, actually I think I shouldn't have merged this. I still get the 127.0.0.1 refused to connect error.

rtitle commented 4 years ago

Hmm ok, looking more. I also just saw some timeouts too.

nturaga commented 4 years ago

How did you test it? Without updating the rockerdev/tidyverse:4.0.0-ubuntu18.04 image to rocker/tidyverse:4.0.0?

https://github.com/rocker-org/rocker-versioned2/blob/master/dockerfiles/Dockerfile_tidyverse_4.0.0

rtitle commented 4 years ago

I applied the change to your branch https://github.com/anvilproject/anvil-docker/tree/update_R_4.0.2 and thought I saw it working -- however now it's not so I may have messed something up. Sorry for the false alarm. OK to leave this merged I think, can make a follow-up PR.