search

anvilproject / anvil-docker

Docker containers for Anvil Project
MIT License
7 stars 9 forks source link

Major Update Bioconductor 3_12. #21

Closed nturaga closed 4 years ago

nturaga commented 4 years ago

The image which the Dockerfile builds in the anvil-rstudio-bioconductor to test is located at nitesh1989/anvil-rstudio-bioconductor:0.0.8

nturaga commented 4 years ago

@rtitle I can't launch this image though on the AnVIL. Any suggestions?

Screen Shot 2020-11-04 at 11 00 49 AM
rtitle commented 4 years ago

Hm, I'll check out the above error.

rtitle commented 4 years ago

@nturaga I think this Leo PR should fix it: https://github.com/DataBiosphere/leonardo/pull/1688

It seems to work in my testing (see PR description). This will need to be merged and included in a Leo release, then we can re-test the nitesh1989/anvil-rstudio-bioconductor:0.0.8 image in prod and hopefully merge this.

nturaga commented 4 years ago

Sounds good to me. I'll follow up

On Thu, Nov 5, 2020, 8:02 PM Robert Title notifications@github.com wrote:

@nturaga https://github.com/nturaga I think this Leo PR should fix it: DataBiosphere/leonardo#1688 https://github.com/DataBiosphere/leonardo/pull/1688

It seems to work in my testing (see PR description). This will need to be merged and included in a Leo release, then we can re-test the nitesh1989/anvil-rstudio-bioconductor:0.0.8 image in prod and hopefully merge this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anvilproject/anvil-docker/pull/21#issuecomment-722737990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU6QS6EMJZ3OLGGA576SNDSONDKPANCNFSM4TKHCDXA .

nturaga commented 4 years ago

Hi @rtitle Any news on the PR making things functional?

rtitle commented 4 years ago

Hey @nturaga, the Leo fix PR was actually merged last week, it should get to deployed to production in today's release @ 4pm.

rtitle commented 4 years ago

The release may not happen today due to some unrelated testing issues -- I'll keep you posted.

nturaga commented 4 years ago

Thanks Rob. Just let me know.

nturaga commented 4 years ago

@rtitle Merge it!

rtitle commented 4 years ago

^ Leo and terra-docker PRs to get this integrated

nturaga commented 4 years ago

@gpcarr @rtitle Will the image be pushed to the GCR under project anvil-gcr-public automatically or should we have to push?

rtitle commented 4 years ago

@nturaga I actually already pushed it: https://console.cloud.google.com/gcr/images/anvil-gcr-public/US/anvil-rstudio-bioconductor?project=anvil-gcr-public&gcrImageListsize=30

I think this will be available in the Terra drop-down in prod once Leo releases next.

nturaga commented 4 years ago

That's great! Thanks.

I will send in a PR for the devel i.e 3.13 version of Bioconductor too today.

On Tue, Nov 10, 2020, 9:09 AM Robert Title notifications@github.com wrote:

@nturaga https://github.com/nturaga I actually already pushed it: https://console.cloud.google.com/gcr/images/anvil-gcr-public/US/anvil-rstudio-bioconductor?project=anvil-gcr-public&gcrImageListsize=30

I think this will be available in the Terra drop-down in prod once Leo releases next.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/anvilproject/anvil-docker/pull/21#issuecomment-724725130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU6QS676F5JOFO4MR5NUZLSPFCR5ANCNFSM4TKHCDXA .