search

anvilproject / anvil-docker

Docker containers for Anvil Project
MIT License
7 stars 9 forks source link

Libpath update to PD #23

Closed nturaga closed 3 years ago

nturaga commented 3 years ago

Allow different versions of Bioconductor to use different directory locations for installation and persistence in GCE.

See corresponding Leo PR for more details: https://github.com/DataBiosphere/leonardo/pull/1821

Screenshots of the Leo + anvil-docker changes working together: Screen Shot 2021-01-19 at 3 37 25 PM

Screen Shot 2021-01-19 at 3 43 25 PM

tested persistence between runtimes as well

rtitle commented 3 years ago

A few comments above but overall the approach looks good.. once this is merged we'll need to push to GCR and also update the static images in terra-docker, and the Leo custom image script.

nturaga commented 3 years ago

Looks good to me too!

gpcarr commented 3 years ago

Looks good to me too!

awesome! i'll go ahead and merge and build the image and push it to GCR as us.gcr.io/anvil-gcr-public/anvil-rstudio-bioconductor:0.0.10. @rtitle we'll have to wait for the next Leo release to set up a terra-docker PR to bump this static image so I'll create a subtask to do that as a reminder

Edit: actually I should be able to PR to terra-docker once this image is pushed right so that the changes to the Leo custom image go out with the next Leo release as well?

rtitle commented 3 years ago

Yup, should be fine to PR and merge terra-docker. Can also regenerate the custom image and PR and merge to Leo. Then next Leo deploy we can update the images in the UI.