search

anvoynov / GANLatentDiscovery

The authors official implementation of Unsupervised Discovery of Interpretable Directions in the GAN Latent Space
416 stars 52 forks source link

Some errors in the code #6

Closed Khushik22 closed 4 years ago

Khushik22 commented 4 years ago

1) In download.py, in line number 27, extra brackets are added while defining choices. choices=[list(SOURCES.keys()) + ['all']], default=['all']) should be choices=list(SOURCES.keys()) + ['all'], default=['all'])

2) In gan_segmentation.py, run_in_background is imported from utils. But, no such function is defined in utils which results in an error.

3) In train_segmentation.py, line numbers 54 and 55 give an error.

4) In train_segmentation.py, line number 219, 'val_dirs=[args.val_images_dirs, args.val_masks_dirs]' gives the following error: attribute error: 'namespace' object has no attribute 'val_images_dirs'

5) In train_segmentation.py, in line numbers 217, 218 and 219, while calling the function train_segmentation, gen_devices hasn't been provided as an argument.

6) In train_segmentation.py, line number 69 gives the following error: AttributeError: 'SegmentationTrainParams' object has no attribute 'test_samples_count'

anvoynov commented 4 years ago

Hi @Khushik22 thank you so much for the report! fixed these issues in the recent commit. https://github.com/anvoynov/GANLatentDiscovery/commit/36704fef8c8d179ec737968b8f7a64cd033af88c

Seems like I have lost some segmentation code updates while refactoring this repo along with https://github.com/anvoynov/BigGANsAreWatching sorry about that.