anxdpanic / plugin.video.youtube

Watch your favorite YouTube content on Kodi
https://ytaddon.panicked.xyz/forum
692 stars 114 forks source link

Context menu « More… » : To Edit playlist #715

Open codegittest opened 6 months ago

codegittest commented 6 months ago

Hello,

First, thanks for this great addon ! And really thanks to support old kodi matrix !

I really appreciate and I’m using this addon from several years now and have 2-3 suggestions to improve friendly user, quick « shortcut » for the most used features to edit and navigate on playlist.

1) on context menu, while logged on playlist, to save some time with IR remote control (or RF keyboard) navigation (mouse on kodi pc is not a problem), could it be possible to move a little upper the choice on list « more… » option ? This is the menu that give the possibility to acces the « related videos » And then « add to… (my list) » the best video! The show me « related videos » really helps to discover new similar video and add them to the actual playlist, if liked, quickly with remote control. These are the 2 best playlist edit option available! Many way to improve, maybe it could be to merge some choice in « more… » menu in the main context menu ? Or, Instead of 8 remote clic down the list to acces « more… » features, it could be the last one on the list, then 1 remote clic upper needed to acces the last item menu would be easier. Or ???

2) I have about 200 videos on a playlist, I have to do next page 7 time to go on the last page to view the last added video. maybe there could be a way to select last page or to select the page number to go around the video we want to play ?

3) It could be really interesting if we could have « search » feature on the context menu, this will avoid to exit the playlist to search anythings.

Thanks for support !

MoojMidge commented 6 months ago

Happy to look at changing some things, but changes would need to be what is useful for the majority of use cases, not necessarily individual preference.

  1. on context menu, while logged on playlist, to save some time with IR remote control (or RF keyboard) navigation (mouse on kodi pc is not a problem), could it be possible to move a little upper the choice on list « more… » option ? This is the menu that give the possibility to acces the « related videos » And then « add to… (my list) » the best video! The show me « related videos » really helps to discover new similar video and add them to the actual playlist, if liked, quickly with remote control. These are the 2 best playlist edit option available!

Not keen on moving the "More..." context menu item, it should be reserved for secondary or less used functions and therefore also lower in the menu than more commonly accessed items.

Many way to improve, maybe it could be to merge some choice in « more… » menu in the main context menu ?

Why don't you create a list of what you would like in the main context menu and in the "More..." menu? Can then see what other users think. If there is a general consensus on re-arranging the menu then happy to do so.

Or, Instead of 8 remote clic down the list to acces « more… » features, it could be the last one on the list, then 1 remote clic upper needed to acces the last item menu would be easier. Or ???

The bottom of the context menu is reserved for the built-in Kodi context menu items. Can't change this, and don't think it is a good idea even if it was possible.

  1. I have about 200 videos on a playlist, I have to do next page 7 time to go on the last page to view the last added video. maybe there could be a way to select last page or to select the page number to go around the video we want to play ?

I can see what is possible, but there are some restrictions on how the pagination of list content works which may mean this is not possible.

  1. It could be really interesting if we could have « search » feature on the context menu, this will avoid to exit the playlist to search anythings.

The context menu is so named because it provides menu items relevant to the context of the selected list item. It is not intended as a general shortcuts menu. If you want to search for something similar to what is selected, then that is what the "Related videos" menu item is for. Adding general shortcuts would add to the length of the menu, making it more difficult to get to items that are relevant to the context - the same thing you have commented about as already being an issue in item 1 above.

codegittest commented 6 months ago

Hello ! Big thank you for fast reply and answer Master coder ! I don’t want to talk for all user, for me, the most used command in the main context menu is, in order: -Play from here (appear 2 time on list upper and bottom) -More… -Remove

Never used: Queue video Watch later Suscribe to « …. » Play with subtitles ( not working with the videos I tried) play with audio Mark as unwatched (on favorite playlist, usualy, it’s good to replay)

This is considering I’m using kodi with infrared remote control or rf keyboard with libreelec or coreelec as OS.

For page selection: Maybe something like « playing from last in list » could bring us to the last page quickly ?

codegittest commented 6 months ago

About search option: without exit playing list (when 10 pages playlist, it’s not quick to exit (and to return to the playlist after) and go to the main home page addon to access to the search option: «  If you want to search for something similar to what is selected, then that is what the "Related videos" menu item is for.«  No. When I need to use search, is not for something similar but something new to look for and probably to add to the playing list if it’s good. If already logged in list name « x », why not search from this and add quickly to this one if liked and fit with the name list ?

neo-neo1 commented 6 months ago

The 1. suggestion reminded me of how long I've yearned for to have "Queue Video" moved to to the top (1 space up). For those of us who Queue videos often, it'll be a huge time saver.

MoojMidge commented 6 months ago

@neo-neo1 - the OP never uses "Queue video" so moving it up won't help them. Can't please everyone, and I'm not keen to make changes just for individual preferences. But open for suggestions, so if you wan't something different, can do so here, and see what others also think and maybe there will be some common requests.

FYI "Queue" is a built-in Kodi action, mapped to the "q" key on a keyboard, and able to be mapped to a remote control button or anything else as well, if you want to access it quickly.

@codegittest - what you are suggesting regarding page selection may not be possible for technical reasons. Regarding search option and moving out of a long navigation history list, one possibility is to add items to go home or perform a quick search from the context menu of the Next page item itself.

codegittest commented 6 months ago

Thanks for support all! yes kodi give « queue » action that could be useful to make playlist from any addon. Thanks for remember this ! However it did’nt help to quickly add new item from main addon playlist with remote (like using related video or search addon feature). Maybe keyboard shortcut button could be interesting for the addon context menu (keymap editor addon works great to config scpecific shorcut when allowed by the addon) OR maybe in the addon setting, there could be some different context menu that user could « load », just to try what user prefer (similar to be able to load an edited « utils.py » file).

For the page selection, thanks for reply, I understand the way it’s programmed, it’s not something possible (related to kodi or API layer ?). I remember, some time ago, there is an option to play list from here in reverse but I don’t think it was switching from first page to the last page. I already have the maximum 50 item per page, maybe allowing more could be a patch ?

About search feature:…. « one possibility is to add items to go home or perform a quick search from the context menu of the Next page item itself. » Yes theses 2 possibility could save many « cursor move » and « exit/select » bottom actions on the remote ! Both could be very user friendly !

Sorry, these was probably already talked in forum, I didn’t read all the threat .

codegittest commented 6 months ago

Hi, Just to let you know, I got some limited succes by editing the utils.py file to upper « more » action in the list. Not sure if so easy to upper at first line but 3th line was relatively easy once I find the good file to modify.

IMG_4242

MoojMidge commented 6 months ago

However it did’nt help to quickly add new item from main addon playlist with remote (like using related video or search addon feature).

Wasn't suggesting that it would be helpful for this, just pointing out that while neo-neo1 uses this function frequently and prefers that this is more easily accessible, you don't use it all. Everyone's usage is different and there are different ways to achieve the same thing.

Maybe keyboard shortcut button could be interesting for the addon context menu (keymap editor addon works great to config scpecific shorcut when allowed by the addon)

There are already a bunch of existing functions that can be mapped to keys or remote control buttons. Quite a few more other functions can also work this way but are currently undocumented.

maybe in the addon setting, there could be some different context menu that user could « load », just to try what user prefer (similar to be able to load an edited « utils.py » file).

Not going to do this. Way too much work for such a niche feature.

For the page selection, thanks for reply, I understand the way it’s programmed, it’s not something possible (related to kodi or API layer ?)

Related to the API, depending on which API is used.

I already have the maximum 50 item per page, maybe allowing more could be a patch ?

Not possible due to API limitations without making multiple requests which is wasteful and will slow things down.

I got some limited succes by editing the utils.py file to upper « more » action in the list.

Modifying the context menu is not as straightforward as it should be for various technical reasons. If you are happy with this, stick with making those changes for yourself at the moment. As I mentioned I am not keen to make changes just for the sake of making changes without a little more input from other users.

The other stuff related to searching and next page navigation actually requires a large number of changes, but these changes are also necessary to fix some other window handling bugs, and are new features that I can see the value of.

neo-neo1 commented 6 months ago

However it did’nt help to quickly add new item from main addon playlist with remote (like using related video or search addon feature).

Wasn't suggesting that it would be helpful for this, just pointing out that while neo-neo1 uses this function frequently and prefers that this is more easily accessible, you don't use it all. Everyone's usage is different and there are different ways to achieve the same thing.

Thanks it was a good suggestion that I forgot about.

codegittest commented 6 months ago

Yes I see that is’nt so easy (« straightforward ») to edit, I’m not a coder and have a lot of respect to you and all of them ! Understand too it’s not same way all people is using this addon and sure, preference is not the same !

if, by improving page navigation and …(?) in the future, maybe this change in code could bring an easy way to add « random » play.

thanks for all ! Keep great work on this !

MoojMidge commented 6 months ago

if, by improving page navigation and …(?) in the future, maybe this change in code could bring an easy way to add « random » play.

Please try to avoid overly broad feature requests. This issue was opened about changing the context menu, but has already moved towards page navigation. Random play is a completely different issue again.

This can also already be done using the "Play all" context menu item on, or from within, a playlist, then choosing "shuffle". If there is a problem with this, then open a new issue so it can be properly discussed/investigated/tracked without getting lost amongst something unrelated.

codegittest commented 6 months ago

Okay, sorry !

MoojMidge commented 6 months ago

No need to apologise, just letting you know the best way to avoid things going unnoticed.

MoojMidge commented 6 months ago

You can test https://github.com/MoojMidge/plugin.video.youtube/releases/tag/v7.0.7%2Bbeta.1 and see if it partially does what you want.

Has various navigation options in the context menu of the Next page item (read the changelog for further details)

codegittest commented 6 months ago

Big thank you ! I did’nt know there was a context menu on the « next page » item ! Great idea to use it ! However I’m not lucky with my api (version ?) when triing to use the page number feature, I get a warning « invalid page token - scpecifies an invalid page token ». By triing the search feature, no warning and did’nt get a windows to edit the search.

I’m using confluence, kodi 19.5 (matrix) with plugin.video.youtube-7.0.7+beta.1.unofficial.1.zip (plugin.video.youtube-7.0.7+beta.1.zip, not working - error content: xbmccontexUI object has no attribute « get_view_manager »).

MoojMidge commented 6 months ago

Please provide a log of the invalid page token and search doing nothing.

codegittest commented 6 months ago

Ok, I have kodi log for invalid page, not sure for search option..

sorry, this log was with: …plugin.video.youtube v7.0.7+beta.1 installed…

kodi log_youtube.txt

MoojMidge commented 6 months ago

That seems to be a log of the AttributeError: 'XbmcContextUI' object has no attribute 'get_view_manager' error using plugin.video.youtube-7.0.7+beta.1

Is there a different error when using plugin.video.youtube-7.0.7+beta.1.unofficial.1.zip?

codegittest commented 6 months ago

Hello, I did’nt found the version 7.0.7+beta.1.unofficial1.1.zip, Here is the log with the …unoficial.1.zip kodi log - 2024-05-05 10-10-45.082.txt

MoojMidge commented 6 months ago

Unfortunately the automatically generated page tokens won't work when jumping through a playlist.

Will need to see if I can figure out anything about the protobuf tokens to see if they can be generated for V1 requests and playlists, otherwise will need to disable it.

It works for more general V3 requests though.

codegittest commented 6 months ago

Ok, really not sure to understand what you mean by« protobuf tokens ».

Just to know, I log into my dev account and I can see « …data API v3 v3 «  and « …Live API v3 » available.

There is something to config with my dev account if you wrote «  It works for more general V3 requests though. » ?

MoojMidge commented 6 months ago

The page tokens are text representations of a bunch of data that identifies each "page" in a Youtube listing. The data is converted to text using the protobuf format.

There is nothing to change in your account. General V3 requests refer to things like the results from a search and trending videos.

codegittest commented 6 months ago

Okay, if I understand, maybe there could be an improvement to the protobuf module if the page information is provided from actual api ? Maybe, no hope to get it working because api did’nt provide the proper data for this kind of control (set page) ? Anyway, thanks a lot for trying to explain !

For quick search option, it is just me not working from new added context menu feature ? It’s working from addon home page…

MoojMidge commented 6 months ago

The API does not provide this information for any arbitrary page, only the previous and next pages relative to the current page.

To get this information for any page in a listing the token has to be generated, but how this is done is not documented anywhere so it has to be reverse engineered.

Regarding the quick search just leave it for now. An updated version will be available shortly.

MoojMidge commented 6 months ago

https://github.com/anxdpanic/plugin.video.youtube/releases/tag/v7.0.7%2Bbeta.1 is available.

Can see if there is any improvement regarding the quick search.

No change for the jump to menu item, it will have to be disabled for listings that can't be navigated in this manner in the next beta.

codegittest commented 6 months ago

Thanks for update and informations ! I’m not at home to try….only next week…