999c1ef255 breaks remmina

any1 / neatvnc

A liberally licensed VNC server library with a clean interface

ISC License

118 stars 29 forks source link

999c1ef255 breaks remmina #25

Closed valpackett closed 4 years ago

valpackett commented 4 years ago

I'm not sure what exactly is to blame, but commit 999c1ef255ee58e4d04b08f8699d36bfccf67692 "tight: Limit rectangle max width according to spec" breaks my connection from Remmina 1.3.9 (the viewer window instantly closes, showing maybe one frame).

any1 commented 4 years ago

Do you have a 4K monitor?

valpackett commented 4 years ago

Yes, but on the client. The server is 2400x1600. I'll try updating remmina just in case..

UPD: same with 1.4.1

any1 commented 4 years ago

I see. I didn't test this, actually. And I see the problem now. The extra rectangle is not included in the count that's sent beforehand.

any1 commented 4 years ago

I reverted the change. Maybe clients don't actually care about this limit.

any1 commented 4 years ago

Should be fixed now.