any1 / neatvnc

A liberally licensed VNC server library with a clean interface
ISC License
118 stars 29 forks source link

server: Add remaining support for simple copy/paste #44

Closed soreau closed 3 years ago

soreau commented 3 years ago
any1 commented 3 years ago

Nice! The rest of the code has { on the same line as if and while. Can you fix that for this and the wayvnc PR also?

any1 commented 3 years ago

Also, we don't use { } when there's only a single line in the code block, so prefer

if (stuff)
    do_stuff();
soreau commented 3 years ago

Nice! The rest of the code has { on the same line as if and while. Can you fix that for this and the wayvnc PR also? Also, we don't use { } when there's only a single line in the code block, so prefer

if (stuff)
    do_stuff();

These should be fixed now.

soreau commented 3 years ago

The length argument is necessary because we're not always guaranteed to be dealing with null terminated strings.

any1 commented 3 years ago

Thanks!