search

any1 / neatvnc

A liberally licensed VNC server library with a clean interface
ISC License
118 stars 29 forks source link

Add `aml` as a git submodule #52

Closed hexcowboy closed 3 years ago

hexcowboy commented 3 years ago

Adding dependency aml as a submodule would simplify the build procedure.

Instead of

git clone "https://github.com/any1/neatvnc.git"
cd neatvnc
mkdir subprojects
cd subprojects
git clone https://github.com/any1/aml.git
cd ..
meson build

A submodule can be installed

git clone "https://github.com/any1/neatvnc.git"
cd neatvnc
git submodule update --init --recursive
meson build

I can create a PR if this project is willing to accept this improvement.

any1 commented 3 years ago

If we do that, then we have to update the submodule ref every time that a change is made to master. Submodules might be slightly nicer for people who just want to build from source, but other than that, they just get in my way.

hexcowboy commented 3 years ago

Understood. Closing for now