any1 / neatvnc

A liberally licensed VNC server library with a clean interface
ISC License
118 stars 29 forks source link

Add missing dependency on libavutil if found #75

Closed pH5 closed 1 year ago

pH5 commented 1 year ago

src/log.c uses av_log_set_level() and av_log_set_callback() from libavutil if HAVE_LIBAVUTIL is set. This causes a build failure if libavutils development packages are installed, but the other dependencies for h264 are not.

any1 commented 1 year ago

There's really no reason to include avutil if h264 is disabled. Better just move config.set('HAVE_LIBAVUTIL', true) to the same place where ENABLE_OPEN_H264 is set for now.

pH5 commented 1 year ago

Moved as suggested.

any1 commented 1 year ago

Thanks!