any1 / neatvnc

A liberally licensed VNC server library with a clean interface
ISC License
126 stars 31 forks source link

test-pixels failing on all big endian architectures #85

Open chewi opened 1 year ago

chewi commented 1 year ago

Both Gentoo and Debian have found that test-pixels fails on all big endian architectures, including ppc32, ppc64, hppa, sparc, and s390x. Debian's logs show that m68k is working, but they disable the tests on that architecture.

See Debian's package logs.

any1 commented 1 year ago

The swap32 macro wasn't working as intended as it was being fed signed integers.

I've fixed that particular issue now, but I still cannot guarantee that the test will pass or that this will even work on those systems. I've never tested this before on big endian.

chewi commented 1 year ago

That's okay, I wouldn't expect you to. Thanks for jumping on this quickly. We'll give it a try.

chewi commented 1 year ago

Sorry, I forgot to report back. I've been told that it sadly didn't work. We only need this for Weston, which has other big endian issues that aren't getting solved in a hurry, but I figured I should reopen this anyway.

any1 commented 1 year ago
Full log written to /<<PKGBUILDDIR>>/obj-powerpc-linux-gnu/meson-logs/testlog.txt
    cd obj-powerpc-linux-gnu && tail -v -n \+0 meson-logs/testlog.txt

That might be useful to have.

chewi commented 1 year ago

I'm just the messenger here, but I've passed that on.

any1 commented 1 year ago

I was looking at debian's package logs that you linked to earlier. Gentoo has that file attached, and it didn't really shed any light on the issue.

I'll need to set up something with qemu to fix this, or wait until sr.ht ci gets a big-endian arch.