search

any2cards / gloomhaven

All of the JSON data files and card images that the GCV utilizes for Gloomhaven
180 stars 59 forks source link

Adding empty battle goal front #18

Closed signed closed 1 year ago

signed commented 1 year ago

Hi, thank you for curating this repository.

we used to pull in gh-battle-goals-front without text from the assets published on google drive, but this recently stopped working. Are you open to add it next to gh-battle-goals-back?

any2cards commented 1 year ago

Are you asking me to host an empty (no-text) front battle goal card? I have never done this before, so I don't know how you were getting it from my repo in the past. The Google Drive you mention is NOT hosted by me.

signed commented 1 year ago

Are you asking me to host an empty (no-text) front battle goal card?

Yes, the ask is to add this to your repository. I can prepare a PR if you want.

I have never done this before, so I don't know how you were getting it from my repo in the past

So far we pulled the card from google drive, not your repository But this stopped working recently and we started to link to some cards here. Before adding gh-battle-goals-front to our repo I reached out to you to add it here for others to find. All the other cards are already here.

any2cards commented 1 year ago

While I am happy to host a blank card for you, I would need to make you aware of three things:

1) I would need to acquire such an asset

2) I would not host it at this Gloomhaven repository as it will soon be deprecated (it will go away). Once Firefox supports Manifest V3 (and some appropriate calls - which in theory should be withing 2 weeks), I will no longer need this repo, and everything will be leveraged from my Worldhaven repo. So I would host your blank battle goal card there.

3) Because I have now signed a license agreement with Cephalofair, I now have to ask them for permission to host templates such as this battle goal card.

signed commented 1 year ago

  1. I would need to acquire such an asset

  2. Because I have now signed a license agreement with Cephalofair, I now have to ask them for permission to host templates such as this battle goal card.

As far as I know the blank battle goal card is part of the Creator Pack V2 that Isaac published under creative commons license BY-NC-SA 4.0. Could you acquire it from there?

  1. I would not host it at this Gloomhaven repository as it will soon be deprecated (it will go away)

Thank you for the heads up. I'll look into the worldhaven repository

any2cards commented 1 year ago

I have loaded the JPG files for both the front and back of the battle goal cards as they existed within the Creator V2 pack. They have been stored here:

https://github.com/any2cards/worldhaven/tree/master/images/templates/gloomhaven

I am closing this ticket.