search

anyaudio / anyaudio-server

:musical_note: Simple server to search youtube and give direct audio download and stream links
91 stars 19 forks source link

Added youtube-dl upgrade scheduler. Closes #123 #124

Closed singhpratyush closed 7 years ago

aviaryan commented 7 years ago

@singhpratyush We would need to restart the server as well, otherwise the changes won't take effect.

Related: Openshift build script

aviaryan commented 7 years ago

Never mind, I see that youtube-dl is being called externally so restarting won't be required. My apologies.

singhpratyush commented 7 years ago

Since the builds are passing, I assume this can be merged now.

singhpratyush commented 7 years ago

Is this working in the new setup?

aviaryan commented 7 years ago

Nice catch. There is no other version of pip installed on the server so we can be sure that if the command is running successfully, conda's pip is running. conda's PATH has been added to .bashrc so maybe it will be recognised.

On the server, I ran the following on the python interpreter (which python) and it worked correctly. Therefore, the scheduler should work I guess. 

import subprocess
subprocess.call("pip install --upgrade youtube-dl", shell=True)
singhpratyush commented 7 years ago

It would work indeed. Thanks for the confirmation.