Improved ui - Githubissues

anyaudio / anyaudio-server

:musical_note: Simple server to search youtube and give direct audio download and stream links

91 stars 19 forks source link

Improved ui #55

Closed ansarimofid closed 8 years ago

ansarimofid commented 8 years ago

Closes #18 #62

singhpratyush commented 8 years ago

Thanks for the contribution @ansarimofid. Please consider these few points :

Keep a placeholder or some loading stuff while images are loading at search or trending page.
Populate About Us and Contact pages if they are really meant to exist.
Do the icons of other destinations at the footer need to exist if they link nowhere?
I'm also not able to download songs. There are no calls made to /api/v1/d. PS: I was not able to download because my AdBlocker was preventing that new tab. May be annoying for users.
5XX status codes are simply ignored. If something bad happens at server, the loading bubbles keep on revolving at the middle.

aviaryan commented 8 years ago

@ansarimofid Are ymp3/static/img/th_3.jpg and other similar files needed ?

bxute commented 8 years ago

Thumbnail image have top and bottom strip, which needs to be cliffed off, image should occupy full height and width. And this is expected to achieve soon, as this is a critical design issue.

ansarimofid commented 8 years ago

Not it's not needed. I did it by mistake. I will take care such issue from next time😉 On 22-Aug-2016 9:56 am, "Avi Aryan" notifications@github.com wrote:

@ansarimofid https://github.com/ansarimofid Is ymp3/static/img/th_3.jpg and other similar files needed ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aviaryan/youtube-mp3-server/pull/55#issuecomment-241312616, or mute the thread https://github.com/notifications/unsubscribe-auth/AIsGT9xgOtLc52NeHKKLbYoY8m5vGQ_Qks5qiSTsgaJpZM4JpMpa .

singhpratyush commented 8 years ago

@ansarimofid : Please solve the issues mentioned and make a ping. Also please mention the person you are addressing while making a comment as it is quite a job to make a guess.

singhpratyush commented 8 years ago

Also please add icon for page if you have anything in mind, for a temporary basis,

ansarimofid commented 8 years ago

@bxute I'm afraid that we may not be able to trim strips since not all the thumbnail have the strips.

ansarimofid commented 8 years ago

@singhpratyush we have fixed minimum height for card to reduce the flickering. @aviaryan temporary thumbnail files has been removed

singhpratyush commented 8 years ago

Please correct the overlay stuff according to pages in home and explore setion.

ansarimofid commented 8 years ago

@singhpratyush All the bugs has been fixed. Please review and merge ASAP