Adds auto suggestion - Githubissues

ansarimofid commented 8 years ago

Adds auto suggestion feature and fixes #71

aviaryan commented 8 years ago

Bugs -

Auto-suggest doesn't work in the search box at /beta
Lots of results are fetched when searching something at /explore . Example, try searching "taylor swift love story cover", writing each word slowly. I guess this is because previous results are not being cleared.

Suggestions -

Show all playlists in the playlist list that comes when you are about to search. Use a scrollbar to keep the size under control. (https://s21.postimg.org/vy2h5x1vb/pop_playlists.png)
Don't send a /search request to server when the query is being typed. Send a request only when the user presses enter.

aviaryan commented 8 years ago

Lots of results are fetched when searching something at /explore . Example, try searching "taylor swift love story cover", writing each word slowly. I guess this is because previous results are not being cleared.

No actually previous requests to /search are being buffered and so the search results list keeps on increasing. Following my suggestion 2 should fix this issue.

singhpratyush commented 8 years ago

Hello @ansarimofid, glad to see the autocomplete working. Please consider these points too -

Getting results while user is typing will be a huge overhead because of the limited resources that we have.

Don't send a /search request to server when the query is being typed.

:+1:

It would be great if you could implement arrow navigation in suggestions.
When the search field is set active (TAB or Mouse Click), the results still remain the same as when left earlier. e.g. suppose i typed in kala chasma and selected kala chasma original from suggestions and moved away so that suggestion bar hides. When I come back to it then i get suggestions according to kala chasma but not kala chasma original, which is not desired. I think you set to show the suggestion panel only when atleast one keyup event has occurred.
When pressing back at /explore, we do not go back at /beta but at /explore?p=... or /explore?q=.... I think that this problem existed earlier too but wasn't noticed. Pleased resolve.

aviaryan commented 8 years ago

Have all the issues been fixed ? @ansarimofid

aviaryan commented 8 years ago

Merging ..

ansarimofid commented 8 years ago

Not all the issues has been fixed. Some are still in progress like

arrow navigation

When pressing back at /explore, we do not go back at /beta but at /explore?p=... or /explore?q=.... I think that this problem existed earlier too but wasn't noticed. Pleased resolve.

Show all playlists in the playlist list that comes when you are about to search. Use a scrollbar to keep the size under control.

singhpratyush commented 8 years ago

@ansarimofid : I will open issues for them.

anyaudio / anyaudio-server

Adds auto suggestion #80