search

anybox / anybox.recipe.odoo

Buildout recipe for Odoo >=8. For older versions please use anybox.recipe.openerp
http://docs.anybox.fr/anybox.recipe.odoo/current/
GNU Affero General Public License v3.0
25 stars 63 forks source link

[FEATURE] Install requirements files of all parts folders #136

Closed rconjour closed 9 months ago

rconjour commented 2 years ago

We noted that the requirements of other parts folders weren't installed. This fix / implementation installs the requirementsfolders of all the parts directories.

StefanRijnhart commented 2 years ago

Can you make this a separate configuration option? Chances are that if I have a lot of OCA repos in my parts, that I don't want to have all the requirements of those unused modules installed.

rconjour commented 2 years ago

Agreed, i updated the PR!

StefanRijnhart commented 2 years ago

Thank you! It seems to me that some code duplication is not necessary. You could consider the apply-requirements-file a specific instance of apply-all-requirements-file, with the odoo path being the only path to install the requirements from. Can you refactor the code likewise? Similarly, the same could said to be true for the parameter itself. Do you think we can change the semantics of apply-requirements-file to take values odoo or all, with true being mapped to odoo for backwards compatibility? Sorry for not considering this in my earlier comment.