anyboxhq / everything-okjson

Submit your feature requests or bug reports here.
https://docs.okjson.app
Apache License 2.0
10 stars 0 forks source link

Left pane breaks when using disclosure triangles with large object #20

Closed kyleridolfo closed 1 year ago

kyleridolfo commented 1 year ago

When using the disclosure triangles to hide or reveal nodes in a large JSON object, eventually the left pane gets into a bad state where the disclosure triangles stop functioning. In some cases, the app will crash.

Steps to reproduce the behavior:

  1. Download the example JSON
  2. Copy its contents into the clipboard so you can paste it into OK JSON (NB: this bug also appears when loading this example from an API endpoint)
  3. Start collapsing sections of content by either clicking the disclosure triangles, or by using the keyboard (ex: click a node to select it, press the left-arrow on your keyboard to collapse it. Continue to press left-arrow to collapse the node's parents.)
  4. What appears to happen is an error in rendering the view. At some point either the app will crash or you will no longer be able to reveal a collapsed node.

Expected behavior I expected the nodes would collapse or expand freely using either keyboard or mouse.

Example Video 1 https://user-images.githubusercontent.com/4280/226183891-157fe70a-84ef-4c36-9c4b-67b53dd24a65.mp4

Example Video 2 / https://user-images.githubusercontent.com/4280/226183998-fc26fe32-7f96-493a-98a3-8e4f0f84d872.mp4

Desktop

Thank you for a great app!

francisfeng commented 1 year ago

Fixed in 1.9.1.