dev-libs/lib{,app}indicator removal - affects games-util/steam-launcher

[aspann]

Hey,

I've just came across this bug: https://bugs.gentoo.org/936881 ...

libappindicator is already masked upstream and will be removed very soon, is there a real reason to provide a (slotted: 2) version of libappindicator and the dependency in games-util/steam-launcher?

(I've locally replaced it and it worked without any issues - the tray icon is still visible)

The patch I've tested:

--- steam-launcher-1.0.0.79.ebuild  2024-02-18 13:37:53.199809250 +0100
+++ steam-launcher-1.0.0.79-r1.ebuild   2024-08-06 21:08:25.234521679 +0200
@@ -82,7 +82,7 @@
            x11-terms/xterm
        ) )

-       trayicon? ( dev-libs/libappindicator:2[abi_x86_32] )
+       trayicon? ( dev-libs/libayatana-appindicator )
    )

    desktop-portal? ( sys-apps/xdg-desktop-portal )

Nvm. many thanks for the great work @steam-overlay! :+1: Cheers!

[unhappy-ending]

Not working for me. Did you remember to unmerge libappindicator?

[aspann]

Not working for me. Did you remember to unmerge libappindicator?

Yep so I did. Using Gnome 46 [private overlay] with this extension: https://extensions.gnome.org/extension/615/appindicator-support

Did you get any errors in the logs when launching via terminal, and have you resetted the steam install afterwards (steam --reset)?

[edit]: Will have a deeper look in a moment..

[unhappy-ending]

I'm on Plasma 6. I force uninstalled libindicator and libappindicator. Then I ran from a terminal STEAM_RUNTIME=0 steam --reset. No dice.

If this is the case, then dev-libs/libindicator will need to be provided by the steam-overlay because even though libappindicator is provided, it still depends on libindicator from the Gentoo tree.

[aspann]

Okay, just re- and double checked..

• no libappindicator installed (neither usptream or :2 from steam-overlay)
• rechecked useflags:

  * Found these USE flags for games-util/steam-launcher-1.0.0.79-r1:
  U I
  + + desktop-portal     : Enable desktop integration, e.g. for file pickers
  + + dialogs            : Support additional dialogs before the client starts
  + + joystick           : Add support for joysticks in all packages
  + + pulseaudio         : Add sound server support via media-libs/libpulse (may be PulseAudio or PipeWire)
  + + steamruntime       : Use the official Steam runtime libraries
  - - steamvr            : Enable SteamVR virtual reality support
  - + trayicon           : Enable system tray icon
  + + udev               : Enable virtual/udev integration (device discovery, power and storage device support, etc)
  + + video_cards_nvidia : VIDEO_CARDS setting to build driver for nvidia video cards
  + + wayland            : Enable dev-libs/wayland backend

• steam --reset
• launched it, no issues (also nothing in the logs)
• btw. using "steamruntime" and not system libs (can recheck on that as well in a moment)

Prove:

[unhappy-ending]

That's because you're using the steam runtime via USE flag. In that case, Steam is providing libappindicator itself. Try STEAM_RUNTIME=0 steam from a terminal, you probably won't have the trayicon. trayicon USE flag is only for when steam runtime is disabled either via USE or env VAR.

[aspann]

yeah.. stupid me .. just recognized that as well .. :/

[unhappy-ending]

lol, oh well. Should probably edit the title now to request dev-libs/libindicator to be included in the overlay.

[aspann]

Will adjust the title in a moment, but before I'm going to check something else.. (as libappindicator should be removed in any-case as it is unmaintained for years now and should not be pulledin by any repo)

[edit]: reminds me to the libnm-glib situation.. :D

[unhappy-ending]

I mean, Steam still depends on gtk+2. You can't remove it, Steam refuses to start if you do. You'd think they'd have phased out gtk+ version 2 years ago.

[aspann]

yeah.. think I'll close this as invalid.

doesn't make sense - maybe esteam can add the lib from a binary-build somewhere directly into the steam runtime dirs... so there won't be any zombie libs in system folders.. ;-)

nvm. thatnks for your feedback and exchange, closing it for now.