search

anycable / anycable-go

AnyCable real-time server
https://anycable.io
MIT License
375 stars 65 forks source link

Implementation of statsd metrics #126

Closed jeremycw closed 2 years ago

jeremycw commented 3 years ago

Hey guys, I took an initial stab at implementing statsd support for metrics. Let me know your thoughts.

Implements https://github.com/anycable/anycable-go/issues/125

palkan commented 3 years ago

Thanks for the PR!

Let me keep open for a time being: I want to refactor the way different instrumentation adapters work, and provide some generic interface. Then we'll be able to plug Statsd easily.

palkan commented 3 years ago

I want to refactor the way different instrumentation adapters work, and provide some generic interface

OK, I finally did it: https://github.com/anycable/anycable-go/commit/52f8d59f67cd0b27ef71d43b8e1810ba82a47dfb

Could you please update your implementation?

jeremycw commented 3 years ago

Cool, I will have a look at this when I have some time.