search

anycable / graphql-anycable

A drop-in replacement for GraphQL ActionCable subscriptions. Works with AnyCable.
MIT License
107 stars 16 forks source link

Add GraphQL ~> 1.12 to test matrix and allow to use other GraphQL version #16

Closed arathunku closed 3 years ago

arathunku commented 3 years ago

All specs pass on GraphQL 1.12, GRAPHQL_RUBY_INTERPRETER is used by default on this version.

There were also no changes to:

  if TESTING_GRAPHQL_RUBY_INTERPRETER
    extend GraphQL::Subscriptions::SubscriptionRoot
  end

because https://graphql-ruby.org/api-doc/1.11.6/GraphQL/Subscriptions/SubscriptionRoot.html Deprecated. This module is no longer needed.

Envek commented 3 years ago

Thank you! :pray:

arathunku commented 3 years ago

No, thank you, @Envek!!! I'll be able to resume work on GraphQL upgrade in the morning :smile:

arathunku commented 3 years ago

@Envek, is there a chance for a release sometime in the future?

Envek commented 3 years ago

But why do you need a release for this? This PR doesn't really changes runtime behaviour of the gem.

arathunku commented 3 years ago

Ahhhhhhhh, nvm, I needed to include graphql-anycable in bundle update explicitly :facepalm: Please ignore me, everything is looking alright!