search

anycable / graphql-anycable

A drop-in replacement for GraphQL ActionCable subscriptions. Works with AnyCable.
MIT License
107 stars 16 forks source link

Using arrays for redis deprecation warnings with redis 4.8.0 #29

Closed smasry closed 1 year ago

smasry commented 1 year ago

There are redis deprecation warnings with redis-rb 4.8.0 for using sadd with a single member

Redis 4.8.0 sadd deprecation warning https://github.com/redis/redis-rb/blob/v4.8.0/lib/redis/commands/sets.rb#L25

The gem currently requires >= 4.2.0 and arrays are accepted in 4.2.0 as well https://github.com/redis/redis-rb/blob/v4.2.0/lib/redis.rb#L1387

Envek commented 1 year ago

Sorry for the late reply. We switched from fakeredis gem to real Redis in tests, so I reverted fakeredis-related stuff from this pull request, and merged.

Thank you!

Envek commented 1 year ago

Finally released in 1.1.6 along with another fix for redis.rb v5