search

anydigital / drupal-tweme

Ultra lightweight Bootstrap theme for Drupal.
https://www.drupal.org/project/tweme
62 stars 9 forks source link

H1, H2 and H3 tags disabling hyperlinks #28

Closed mikedzl closed 9 years ago

mikedzl commented 9 years ago

I know this sounds crazy but it appears that the theme is somehow disabling the hyperlink functionality in body content that is wrapped in H1, H2 and H3 tags.

H4 and H5 tags allow links as does block level H1, H2 and H3 tags.

Switching the theme in Drupal from Tweme allows the hyperlink in the tags to work in the body content.

mikedzl commented 9 years ago

Got it figured out - it was the CSS in style.css (line 91 of style.less) copied below. If this was intentional then that's a pretty clever trick to force links to not work. ;-)

.region-content h1, .region-content h2, .region-content h3 { margin-top: -7rem; padding-top: 8rem; position: relative; z-index: -1; }

Great work on this theme BTW!

tonystar commented 9 years ago

Your truth. This is because of negative z-index. Solution is to make positive value for elements inside headings. I'll try to fix it today or tomorrow!

tonystar commented 9 years ago

Hmm. The issue is not that simple! It takes more time than I expected.

By the way good joke J

mikedzl commented 9 years ago

Removing all of that code resolved the issue for me. I had however modified the page.tpl.php to move the <?php print $title ?> from the top jumbotron area to above the content as well as <?php print $breadcrumb ?>.

I've seen things overlap and break links before however so you may still be experiencing that in the jumbotron area with those two items.

Best of luck, the theme is awesome and helped me greatly in speeding up the development of a site I am working on. I will be sure to shoot you a note on Twitter when it's launched so you can see what I've built off your awesome base with Tweme. :)

mikedzl commented 9 years ago

Below is my modified page.tpl.php template which no longer has the problem for reference and quick drop in checking for you ;-)

http://myaccount.dropsend.com/file/37969f904825c59e (link valid for 7 days from post)

I put the breadcrumb below <?php print render($page['highlighted']) ?> and title below <?php print render($title_prefix) ?> - I also took the title out of the <?php if (!empty($title) && !$page['header']): ?>.

tonystar commented 9 years ago

Fixed in 7.x-3.0-beta2!

Regarding page.tpl.php: could you please describe the issue forcing you to change the page template?