search

anymail / django-anymail

Django email backends and webhooks for Amazon SES, Brevo (Sendinblue), MailerSend, Mailgun, Mailjet, Postmark, Postal, Resend, SendGrid, SparkPost, Unisender Go and more
https://anymail.dev
BSD 3-Clause "New" or "Revised" License
1.67k stars 129 forks source link

Inbound: better handle inline parts #330

Closed martinezleoml closed 1 year ago

martinezleoml commented 1 year ago

Relates to #327.

medmunds commented 1 year ago

Wow, this looks great! Thanks.

My only suggestion would be to add a test for the new inlines list property, verifying that it includes inline parts both with and without content-ids (to cover the Apple Mail case you originally reported).

martinezleoml commented 1 year ago

Good catch! I've added a test in a separate commit (feel free to squash it or event edit my previous commits if needed).

By the way, thanks a lot for being reactive on reviewing this. ;)

medmunds commented 1 year ago

Thanks.

In the docs, I updated a bunch of email.message.Message → EmailMessage refs and added some Sphinx "versionadded" and "versionchanged" info; I also fixed some now-outdated comments in the code; and credited you in the changelog.

medmunds commented 1 year ago

Oops, closes #327. (And #328, I guess.)

martinezleoml commented 1 year ago

Thanks for the credits and for your help. ;)