MailPace: New ESP - Githubissues

anymail / django-anymail

Django email backends and webhooks for Amazon SES, Brevo (Sendinblue), MailerSend, Mailgun, Mailjet, Postmark, Postal, Resend, SendGrid, SparkPost, Unisender Go and more

https://anymail.dev

BSD 3-Clause "New" or "Revised" License

1.65k stars 125 forks source link

MailPace: New ESP #354

Closed paul-oms closed 6 months ago

paul-oms commented 6 months ago

Hi Anymail team, thanks for building such well designed and easy to extend software! We're an ESP (https://mailpace.com) that would like to be fully out of the box with you.

Let us know if there's more we need to do, or improvements to the code that we can make.

[x] Backend
[x] Webhooks
[x] Inbound
[x] Tags
[x] Tests
[x] Docs
[x] Readme/project/tox/workflows etc.

paul-oms commented 6 months ago

More issues than expected on the other Python versions - we'll fix them locally and re-open a PR once complete (with signed commits)

medmunds commented 6 months ago

Thanks, looking forward to it!

One problem causing multiple failing tests is the optional library: anymail.webhooks.mailpace needs to be importable whether or not pynacl is installed. There's a decent example of how to handle that in anymail.webhooks.resend.

paul-oms commented 6 months ago

Thanks! I've attempted that pattern in the new PR 🤞