anyproto / any-sync-dockercompose

docker-compose for testing any-sync
MIT License
238 stars 30 forks source link

Correct admin ports #24

Closed sij-ai closed 4 months ago

sij-ai commented 4 months ago

Corrected transposition of external/internal admin ports



Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

github-actions[bot] commented 4 months ago

CLA Assistant Lite bot:
Thank you for your pull request, we really appreciate it!

Please sign our Contributor License Agreement before we can accept your contribution.
You can sign the CLA by simply commenting on this pull request with the following text.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

sij-ai commented 4 months ago

Unless I'm missing something, the two external and internal ports were transposed here. Reversing did fix the docker container for me, after hours of troubleshooting.

sij-ai commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

fb929 commented 4 months ago

@iodrift your changes are breaking any-sync-admin what is your point? do you want to change "listen port" on host machine?

fb929 commented 4 months ago

https://github.com/anyproto/any-sync-dockercompose/pull/26 I'm added setting for configure external web-admin port