anyproto / any-sync-dockercompose

docker-compose for testing any-sync
MIT License
394 stars 56 forks source link

Fix pull access warnings for local builds #72

Closed hellodword closed 5 months ago

hellodword commented 5 months ago


Description

https://docs.docker.com/compose/compose-file/05-services/#image

image may be omitted from a Compose file as long as a build section is declared

But on my machine, it will try to pull these images, not to build them:

! generateconfig-anyconf Warning pull access denied for generateconfig-anyconf, repository does not exist or may require 'docker login': denied: requested access to the resource is d...
$ docker compose version 
Docker Compose version 2.27.2

$ docker version 
Client:
 Version:           24.0.9
 API version:       1.43
 Go version:        go1.22.3
 Git commit:        v24.0.9
 Built:             Thu Jan  1 00:00:00 1970
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          24.0.9
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.22.3
  Git commit:       v24.0.9
  Built:            Tue Jan  1 00:00:00 1980
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.18
  GitCommit:        v1.7.18
 runc:
  Version:          1.1.12
  GitCommit:        
 docker-init:
  Version:          0.19.0
  GitCommit:  

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

github-actions[bot] commented 5 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

hellodword commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

fb929 commented 5 months ago

it seems that your changes don't remove the warning. it would be more appropriate to simply remove image: for local builds.

hellodword commented 5 months ago

it seems that your changes don't remove the warning.

The changes do remove the warning for me. I'm not sure if they work with other versions.

it would be more appropriate to simply remove image: for local builds.

Yes, it's what I always did in the past. I was avoid to remove something required by this project. I'll update the commit.

fuksman commented 4 months ago

@any contributor @hellodword infra