Made the restart policies of Docker containers more consistent

pendyurinandrey commented 3 months ago

[x] I understand that contributing to this repository will require me to agree with the CLA

Description

I tried using Anytype as my own self-hosted note app and encountered an issue. When I deployed Anytype following the instructions in the README.md, the cluster worked well initially. However, after rebooting the VM, I noticed that while some Docker containers automatically started, others did not (specifically, Mongo, Coordinator, and Tools). After a brief investigation, I realized that the 'restart' policies of the containers were inconsistent. I have prepared this PR to address and fix this inconsistency.

Impact analysis: Based on the README.md, this project is intended for development and launching small personal clusters. I believe my changes will not negatively impact any users.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 tech-docs
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

pendyurinandrey commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

pendyurinandrey commented 3 months ago

recheck

fb929 commented 3 months ago

@pendyurinandrey I think that a more suitable policy would be "unless-stopped", because the "always" policy will always start containers when the Docker daemon restarts, even if the user manually stopped them and doesn't want them to start.

pendyurinandrey commented 2 months ago

@fb929 I didn't use unless-stopped initially because of an old Docker bug https://github.com/docker/for-linux/issues/652. I retested this bug using following configuration:

docker --version
Docker version 27.2.0, build 3ab4256

lsb_release -d
Description:    Ubuntu 24.04.1 LTS

It was not reproduced. I might be still valid for other OS or Docker versions, but I cannot check it. I updated always to unless-stopped in this PR.

anyproto / any-sync-dockercompose