anyproto / anytype-ts

Official Anytype client for MacOS, Linux, and Windows
https://anytype.io
Other
3.73k stars 220 forks source link

Links with uncommon URI schemes don't work #696

Closed adriancampos closed 2 months ago

adriancampos commented 2 months ago

Have you read a contributing guide?

Current Behavior

Currently, links with a custom uri scheme aren't clickable. For example, a link that points to vscode://file/project doesn't show anything on hover or do anything on click. It behaves like regular text.

Expected Behavior

The link should attempt to open when clicked.

Steps To Reproduce

  1. Create a link with value vscode://file/project
  2. Click on the link, expect it to open the link
  3. Compare with mailto://path or other allowed URI schemes

Environment

- OS: Windows 11
- Version: 0.40.8

Anything else?

It seems that specific schemes are explicitly allowed here. Is there a reason to not allow everything? If so, could a confirmation box (like the one in Chrome) be implemented for schemes that aren't automatically allowed?

ra3orblade commented 2 months ago

Fixed.