search

anyswap / CrossChain-Bridge

Cross-Chain bridge based on Anyswap MPC network.
GNU General Public License v3.0
281 stars 162 forks source link

add colx #13

Closed tinhnguyenhn closed 3 years ago

jowenshaw commented 3 years ago
  1. Please pass the following checks of pull request. run make all report undefined: colxutil
  2. Suggest rebase your commits on the latest anyswap:master branch should update tokens/colx/signtx.go accordingly (ref. tokens/btc/signtx.go)
tinhnguyenhn commented 3 years ago
  1. Please pass the following checks of pull request. run make all report undefined: colxutil
  2. Suggest rebase your commits on the latest anyswap:master branch should update tokens/colx/signtx.go accordingly (ref. tokens/btc/signtx.go)

I updated. Thanks!

jowenshaw commented 3 years ago
  1. Please pass the following checks of pull request. run make all report undefined: colxutil
  2. Suggest rebase your commits on the latest anyswap:master branch should update tokens/colx/signtx.go accordingly (ref. tokens/btc/signtx.go)

I updated. Thanks!

still not solved problem 1. this problem is about repository github.com/tinhnguyenhn/colxd

the following is the concrete compiling error:

github.com/tinhnguyenhn/colxd/txscript
# github.com/tinhnguyenhn/colxd/txscript
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:74:14: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:104:17: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:168:50: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:234:57: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:346:9: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:350:22: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:353:37: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:361:12: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:365:25: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:368:43: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:368:43: too many errors

you can run make all in your forked repository https://github.com/tinhnguyenhn/CrossChain-Bridge.git to reproduce the above compile error.

Also you can see here https://github.com/anyswap/CrossChain-Bridge/pull/13 if all checks are passed. For example, the current state is All checks have failed, means the pull request still have some problem.

tinhnguyenhn commented 3 years ago
  1. Please pass the following checks of pull request. run make all report undefined: colxutil
  2. Suggest rebase your commits on the latest anyswap:master branch should update tokens/colx/signtx.go accordingly (ref. tokens/btc/signtx.go)

I updated. Thanks!

still not solved problem 1. this problem is about repository github.com/tinhnguyenhn/colxd

the following is the concrete compiling error:

github.com/tinhnguyenhn/colxd/txscript
# github.com/tinhnguyenhn/colxd/txscript
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:74:14: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:104:17: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:168:50: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:234:57: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:346:9: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:350:22: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:353:37: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:361:12: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:365:25: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:368:43: undefined: godashutil
/go/pkg/mod/github.com/tinhnguyenhn/colxd@v0.0.0-20210412084321-d9a38d090019/txscript/sign.go:368:43: too many errors

you can run make all in your forked repository https://github.com/tinhnguyenhn/CrossChain-Bridge.git to reproduce the above compile error.

Also you can see here https://github.com/anyswap/CrossChain-Bridge/pull/13 if all checks are passed. For example, the current state is All checks have failed, means the pull request still have some problem.

thank you. I will check it again

jowenshaw commented 3 years ago

15 pull request is merged which is same as this one.

So close this pull request.