Add validation testing to deployment

anyweez / sorjs.com

Serverside content for sor client

https://sorjs.com

0 stars 0 forks source link

Add validation testing to deployment #4

Open anyweez opened 8 years ago

anyweez commented 8 years ago

Deployment should not be able to proceed if:

Challenges are missing their tests file.
JSON isn't valid according to the sor spec (that needs to be written). Validate with something like https://www.npmjs.com/package/json-validation.
Need to do something to catch for malicious code in sample? Or just require that samples be very short and therefore easy for humans to review quickly.
Maybe more?

anyweez commented 8 years ago

JSON schema v1 is safe to lock. Correctly rendering all assets at this point.

anyweez commented 8 years ago

Added JSON schema definition and validation in https://github.com/anyweez/sorjs.com/pull/8. Still need to check to make sure that the specified tests file exists.

For now I'm going to rely on manual review for detecting malicious code in tests.

anyweez commented 8 years ago

Modified deployment script so that only changes to master are deployed automatically.

anyweez commented 8 years ago

This is Done Enough for the initial launch. I'm going to keep the issue open so that I can potentially clean this up some down the road but it feels fairly solid now.