search

anyx / LoginGateBundle

59 stars 23 forks source link

Symfony 5 compatibility. #38

Closed Philippe-B- closed 1 year ago

Philippe-B- commented 1 year ago

Hi. I guess Symfony 5 compatibility has been dropped by mistake?

https://github.com/anyx/LoginGateBundle/commit/12e08785a29f31194d999e0f30e1cbd3e16d9dea#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

anyx commented 1 year ago

Hi @Philippe-B- Right now you can use version 2.0.3 with symfony 5 https://github.com/anyx/LoginGateBundle/releases/tag/2.0.3

Philippe-B- commented 1 year ago

Thanks for your fast reply. I originally intended to use version 2.0.3 but it throws an error at login about a missing 'username' column. I don't know if it's due to an issue in the project I'm working on, but a quick test with version 3 (manual install) fixed it.

I since managed to install the bundle by adding a forked repository in my composer.json and requiring a branch, with a fix, whose name begins with 'dev-'. I made a PR to merge this fix here.

There are probably several better ways to fix my issue, but it's an old project from a low budget customer that I upgraded from Sf3, I was not given enough time to do more. Fixing your issue is the better option to me for now.

anyx commented 1 year ago

@Philippe-B- thanks for PR. Just pushed 3.0.1 version with it

Philippe-B- commented 1 year ago

Great! Thank you.