search

anz-bank / pkg

Common ANZ Go packages
https://pkg.go.dev/github.com/anz-bank/pkg
Apache License 2.0
2 stars 9 forks source link

Log API Refactor #22

Closed nofun97 closed 4 years ago

nofun97 commented 4 years ago

Fixes #19

Removed WithFunc and changed WithCtxRef to WithContextRef for clearer name.

jamesrom commented 4 years ago

I'm happy to approve this, but what are your thoughts on WithCtxKey or WithContextKey? We're not passing a reference, and the context package calls it 'key'.

anzboi commented 4 years ago

I second that, I think i prefer context key. Objections?

anzdaddy commented 4 years ago

WithContextKey sgtm

nofun97 commented 4 years ago

changed to WithContextKey