anz-bank / sysl-catalog

sysl-catalog (no, not catalogue): A static site generator for web service documentation

https://demo.sysl.io/

Apache License 2.0

7 stars 7 forks source link

Copy spec files to output folder #193

Closed cuminandpaprika closed 4 years ago

cuminandpaprika commented 4 years ago

This PR changes the way Redoc imports specifications back to copying the specification files to the output folder, so that it works with private Github repositories. In the previous change, a CORS proxy does enable the specification file to be accessed by the generated Redoc page but only for Public repositories

Reverts the following commits:

https://github.com/anz-bank/sysl-catalog/pull/189/commits/9d98469d716f45eb839c5db3dde02f5a98757dc6 https://github.com/anz-bank/sysl-catalog/pull/189/commits/987eb5d627e2bb0207793bbb7f8efdb77f66ef9d

Checklist:

[x] Added tests
[x] Updated documentation

codecov[bot] commented 4 years ago

Codecov Report

Merging #193 into master will decrease coverage by 0.17%. The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   54.27%   54.09%   -0.18%     
==========================================
  Files           6        6              
  Lines         925      928       +3     
==========================================
  Hits          502      502              
- Misses        365      367       +2     
- Partials       58       59       +1

Impacted Files	Coverage Δ
pkg/catalog/redoc.go	`77.77% <ø> (ø)`
pkg/catalog/spec.go	`82.00% <72.72%> (-6.00%)`	:arrow_down:
pkg/catalog/generator.go	`67.97% <100.00%> (+0.54%)`	:arrow_up:

github-actions[bot] commented 4 years ago

This pull request is being automatically deployed to Netlify.

🔍 Logs: https://app.netlify.com/sites/lucid-franklin-43e899/deploys/5f32593c76f264c34e570c9c ✅ Preview: https://5f32593c76f264c34e570c9c--lucid-franklin-43e899.netlify.app