anz-bank / sysl-go

Communication library used by SYSL-generated code written in Go.
Apache License 2.0
10 stars 14 forks source link

Make json validate optional/configurable. #182

Closed springwiz closed 4 years ago

springwiz commented 4 years ago

Allow sysl-go adoption teams to opt out of json validation of sysl types.

anzdaddy commented 4 years ago

@springwiz What does "json validation of sysl types" mean, exactly?

springwiz commented 4 years ago

@anzdaddy We have recently introduced a feature wherein we validate the presence of a value in the mandatory fields of the sysl types when used in a request body. bah-bff team still don't mark all the field types as optional even though they don't pass a value. The feature breaks their build pipeline when migrated to arrai based code generation.

anzdaddy commented 4 years ago

Is it a lot of work to add the optional qualifier?

springwiz commented 4 years ago

Not really, just a few tweaks in the transform.