search

anz-bank / sysl-go

Communication library used by SYSL-generated code written in Go.
Apache License 2.0
10 stars 14 forks source link

sysl-go needs to use a stable version of arrai #206

Open nydrani opened 4 years ago

andrewemeryanz commented 4 years ago

Related: https://github.com/anz-bank/sysl-go/issues/28

andrewemeryanz commented 4 years ago

An error was introduced in arrai version v0.136.0 where newlines were not being inserted in some instances.

An example can be found in when generating svc_service.arrai (line 65):

// built with arrai v0.135.0
u.RawQuery = q.Encode()
result, err := restlib.DoHTTPRequest(...)

// built with arrai v0.136.0
u.RawQuery = q.Encode()result, err := restlib.DoHTTPRequest(...)
orlade-anz commented 4 years ago

I'd recommend the arraiw pattern that other repos use. We will probably move to running arrai via Docker at some point, and when we do, we can update all arraiw repos at once.

orlade-anz commented 4 years ago

Note that this kind of issue will also be caught by the blueprints tool once it goes into "production" (i.e. CI).

https://github.com/anzx/blueprints/pull/1

joshcarp commented 4 years ago

An error was introduced in arrai version v0.136.0 where newlines were not being inserted in some instances.

An example can be found in when generating svc_service.arrai (line 65):

// built with arrai v0.135.0
u.RawQuery = q.Encode()
result, err := restlib.DoHTTPRequest(...)

// built with arrai v0.136.0
u.RawQuery = q.Encode()result, err := restlib.DoHTTPRequest(...)

If you really wanna be risky you can just put semi colons in where the newlines are meant to be and let go fmt do the rest

anzdaddy commented 4 years ago

The new autogen facility already uses version-tagged docker images.