Closed jstarry closed 1 week ago
Attention: Patch coverage is 73.61111%
with 19 lines
in your changes are missing coverage. Please review.
Project coverage is 82.7%. Comparing base (
b711bda
) to head (cf49ac2
). Report is 1 commits behind head on master.
I wasn't planning on backporting but could be nice actually. But we would definitely need the merging logic if we did backport because otherwise old versions would be deserializing but not picking up necessary epoch stakes entries from new snapshots.
rebased to fix conflicts (just imports)
Discussed with @brooksprumo and not planning to backport this.. phase 2 of the new field migration will be implemented for v2.1
Discussed with @brooksprumo and not planning to backport this.. phase 2 of the new field migration will be implemented for v2.1
Sorry for not chiming in, but this is my preferred approach also 🤝
automerge label removed due to a CI failure
Fixed a bad conflict resolution, can I get another approval?
Problem
Epoch stakes are not serialized into bank snapshots with the stake credits_observed field which is highly desired for implementing snapshot recovery of partitioned epoch rewards state.
Summary of Changes
Implements phase 1 of SIMD-0149 by deserializing the new epoch stakes map field from the bank snapshot if it exists. If the map is deserialized, it will be merged with the old epoch stakes field entries.