anza-xyz / agave

Web-Scale Blockchain for fast, secure, scalable, decentralized apps and marketplaces.
https://www.anza.xyz/
Apache License 2.0
178 stars 67 forks source link

Refactor nonce rollback to remove overly complex code #1428

Open jstarry opened 2 weeks ago

jstarry commented 2 weeks ago

Problem

Nonce rollback code is overly complex and hard to read. This mess is making it hard to implement handling for transactions that skip execution but are still committed as part of SIMD-0082

Summary of Changes

Refactor with more descriptive types / scenarios

Fixes #

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.7%. Comparing base (ef8d362) to head (54a7104). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1428 +/- ## ======================================= Coverage 82.7% 82.7% ======================================= Files 871 871 Lines 370249 370150 -99 ======================================= - Hits 306391 306311 -80 + Misses 63858 63839 -19 ```