anza-xyz / agave

Web-Scale Blockchain for fast, secure, scalable, decentralized apps and marketplaces.
https://www.anza.xyz/
Apache License 2.0
450 stars 220 forks source link

JIT compile regression #3493

Open alessandrod opened 2 weeks ago

alessandrod commented 2 weeks ago

As part of working on https://github.com/anza-xyz/agave/pull/3481 we discovered that program_cache_us times seem to have regressed in 2.0.

Screenshot 2024-11-06 at 10 55 01 am

https://github.com/anza-xyz/agave/pull/3481#issuecomment-2458062024

Something is off in the executor metrics too, jit_compile_us doesn't seem to be aggregated correctly.

alessandrod commented 2 weeks ago

@bw-solana @Lichtso @buffalojoec moving to this issue since I landed and closed the original PR

@Lichtso this smells like a JIT regression in rbpf

Also someone fix the jit metrics pls

buffalojoec commented 2 weeks ago

@alessandrod I'll look into metrics asap

Lichtso commented 2 weeks ago

Um, are we sure that it is in v2.0? Because so far I have only seen comments about v2.1

alessandrod commented 2 weeks ago

Left is master, right is 2.0, so yeah seems to be in 2.0 too

Screenshot 2024-11-06 at 5 38 37 pm
alessandrod commented 2 weeks ago

after a few hours looks like it got significantly worse

Screenshot 2024-11-06 at 9 45 50 pm