search

anza-xyz / move

Move compiler targeting llvm supported backends
https://discord.gg/wFgfjG9J
Apache License 2.0
108 stars 34 forks source link

Add PR link to commit message #272

Closed ksolana closed 1 year ago

ksolana commented 1 year ago

we can probably write a github action to amend the commit message with a link to PR. This will simplify tracking of the PR and browse the reviews that went with it.

or is there a better way?

docs on actions: https://dev.to/knowbee/how-to-setup-continuous-deployment-of-a-website-on-a-vps-using-github-actions-54im

yihau commented 1 year ago

I think maybe just force this repo can only squash merging into branches 🤔 the monorepo is a good example. all commits are PRs and will have the PR number in the message.

Screenshot 2023-08-16 at 12 44 14 AM
dmakarov commented 1 year ago

I would prefer we keep the rebase and merge option. I don't like multiple commits of a PR being squashed into a single commit. Otherwise I would have to make separate PRs for each commit, if I want to preserve the logic and granularity of changes.

yihau commented 1 year ago

right. squashing will destroy the granularity. To me, I'm just a little worried about whether it is too aggressive to modify every commit message but let me have a poc and will share it here!

dmakarov commented 1 year ago

I’m not sure that every commit needs this. Maybe only the first or the last commit of a PR is sufficient.

yihau commented 1 year ago

okay! it will be better if we can accept only the first or the last including it! I think I will get it happen in a command 🤔 the scenario looks like

1) we open a PR 2) discuss and update ... 3) before we merge it, we trigger bot to amend the message 4) merge it

does this one what we expect?

dmakarov commented 1 year ago

Sounds good to me, @yihau . Thanks.