search

anza-xyz / move

Move compiler targeting llvm supported backends
https://discord.gg/wFgfjG9J
Apache License 2.0
108 stars 33 forks source link

Yet another attempt to fix CI handling of comment text #327

Closed dmakarov closed 1 year ago

dmakarov commented 1 year ago

This change attempts to prevent any subcommand expansions when body of a comment is echoed.

dmakarov commented 1 year ago

@yihau, We also have intermittent errors on Add PR Links job.

https://github.com/solana-labs/move/actions/runs/6074732000/job/16479415454

dmakarov commented 1 year ago

test a comment with parenthesis this shouldn't be $(a subcommand)

yihau commented 1 year ago

I'm thinking maybe we can add this condition https://github.com/solana-labs/move/blob/9982d16de291d1aa7ac684b485875f48de8099a6/.github/workflows/pr-commands.yml#L39 to prevent we parse so various comments. let me test it later!

yihau commented 1 year ago

We also have intermittent errors on Add PR Links job.

oh no 😢 let me check the PR links action later!

dmakarov commented 1 year ago

I'm thinking maybe we can add this condition

https://github.com/solana-labs/move/blob/9982d16de291d1aa7ac684b485875f48de8099a6/.github/workflows/pr-commands.yml#L39

to prevent we parse so various comments. let me test it later!

Sounds good, but let's also use cat and sed for filtering as is done in this PR, maybe.