search

anza-xyz / move

Move compiler targeting llvm supported backends
https://discord.gg/wFgfjG9J
Apache License 2.0
108 stars 33 forks source link

Fix stdlib unit test that depend on address length and vector representation #332

Closed dmakarov closed 1 year ago

dmakarov commented 1 year ago

Motivation

These Move stdlib unit tests depend on the length of Address, Endianness and Vector value representation. The expected results in these tests do not match the actual results produced by Move to Solana compiler.

This PR adjusts the expected results to match what is expected on Solana from the operations performed in the tests.

Test Plan

These are fixes to tests themselves.

Resolves #329

dmakarov commented 1 year ago

@yihau, For some reason when PR is created the checks don't show our pre-land checks but immediately displayed as All checks have passed, with only 1 successful check. Please, see below.

However, the CI jobs for pre-land checks are running https://github.com/solana-labs/move/actions/runs/6084019653

yihau commented 1 year ago

I received lots of incident mails from Github today. maybe this one is the victim as well 🫠

(btw, they just fixed Actions about 1 hr ago and the Git Operations is still firing )

dmakarov commented 1 year ago

I received lots of incident mails from Github today. maybe this one is the victim as well 🫠

(btw, they just fixed Actions about 1 hr ago and the Git Operations is still firing )

I don't know if it's related or not. I noticed this started several days ago. On additional pushes to the PR branch the checks seem to appear correctly. Hopefully, this is resolved somehow.

yihau commented 1 year ago

true! I got Actions incident mails at Sep 4, 14:21 UTC and Aug 29, 01:59 UTC as well. feel free to ping me if it happen again!