search

anza-xyz / move

Move compiler targeting llvm supported backends
https://discord.gg/wFgfjG9J
Apache License 2.0
108 stars 33 forks source link

Cleaning ir-tests #335

Closed jcivlin closed 11 months ago

jcivlin commented 1 year ago

Remnants of previous run may falsely help test to pass. Cleaning.

jcivlin commented 1 year ago

It did not trigger any check on CI. I files #336.

dmakarov commented 1 year ago

It did not trigger any check on CI. I files #336.

it did https://github.com/solana-labs/move/actions/runs/6094184452 but they don't appear on this page. this has nothing to do with PR includes only test related changes #336

yihau commented 1 year ago

the flow looks like:

1) create a PR 2) add-pr-link and other tests are triggered 3) add-pr-link completed and force push code 4) due to github-actions bot doesn't trigger any Github Actions so the status check becomes empty. (just like this PR)

but we don't cancel the actions which are triggered by 2) so the link is from there.

jcivlin commented 1 year ago

but we don't cancel the actions which are triggered by 2) so the link is from there. @yihau so, what should be corrected?

yihau commented 1 year ago

we had a patch. unfortunately it will work in the next time when you create a PR. (it will look like this one https://github.com/solana-labs/move/pull/342)

ksolana commented 11 months ago

please merge the file if you are okay with it.

jcivlin commented 11 months ago

Replaced by #385. Closing.