search

anza-xyz / move

Move compiler targeting llvm supported backends
https://discord.gg/wFgfjG9J
Apache License 2.0
108 stars 33 forks source link

[Bug] CI does not trigger checks if PR includes only test related changes #336

Closed jcivlin closed 1 year ago

jcivlin commented 1 year ago

🐛 Bug

See example https://github.com/solana-labs/move/pull/335

joeaba commented 1 year ago

@yihau

dmakarov commented 1 year ago

@yihau never mind the title of this issue. The problem is not related to whether PR includes only test related changes or not. I think the issue may be with the add-pr-link workflow. Somehow GH uses that workflow to populate the checks on the PR page maybe.

dmakarov commented 1 year ago

@yihau when more commits are pushed or force pushed to an existing PR, the add-pr-link workflow is not triggered, but the llvm-ci-pre-land workflow is triggered, and the checks appear on the PR page as expected. So it's definitely a problem with add-pr-link being triggered on PR creation.

yihau commented 1 year ago

checking 🫠

jcivlin commented 1 year ago

@dmakarov, I believe the good practice is to let the author of the issue to close it.

dmakarov commented 1 year ago

@dmakarov, I believe the good practice is to let the author of the issue to close it.

@jcivlin You can believe whatever you want. The issue was closed by GH automatically when I merged the PR that Yihau designated as resolving your issue. I did not close your issue. Learn how tools work before stating your believes.

jcivlin commented 1 year ago

I'm referencing to this image

And I do not understand why your answers are so condescended.

dmakarov commented 1 year ago

I'm referencing to this image

And I do not understand why your answers are so condescended.

That is what GH does when a user merges a PR that has a comment "Close #NNN" or "Resolve #NNN". I merged Yihau PR #339, which has a comment "Close #336". I merged Yihau's PR because Yihau doesn't have permissions to merge PRs in this repository. If Yihau merged his PR his name would appear as closing your issue. I personally did not close your issue and did not interfere with your believes of good practice. So I don't need to be trolled and/or lectured about good practices. I consider your comments provocative and trolling. If you paid just a little attention to how GH works you might reconsider making such comments. You can always reopen your issue if you believe that it wasn't resolved and instead of complaining about me closing your issue, which I did not. Is this clear?