[PR commands] check-lint

anza-xyz / move

Move compiler targeting llvm supported backends

https://discord.gg/wFgfjG9J

Apache License 2.0

107 stars 32 forks source link

[PR commands] check-lint #357

Open yihau opened 10 months ago

yihau commented 10 months ago

@check-lint: run the linter (clippy + fmt).

yihau commented 10 months ago

we have this one atm https://github.com/solana-labs/move/blob/16ed36ab8d0815dd25372107765619078306109f/.github/workflows/llvm-ci-pre-land.yml#L42-L65

and it will be triggered either

create a PR
push new code

do we still need this command and when do you use it?

dmakarov commented 10 months ago

I’m not sure about commands in general. I don’t see myself ever needing to use them. However the lint check I absolutely want to see run and pass without errors before anything is merged to GH solana-labs/move repository. I would also second making this check ‘required’ in GH repository settings, so that merging is blocked when this check hasn’t passed.

ksolana commented 9 months ago

let's implement this as it also sets background work for future commands to build/run specific targets.