search

anza-xyz / platform-tools

Apache License 2.0
47 stars 32 forks source link

Add Windows build job and build.sh support #20

Closed joncinque closed 3 years ago

joncinque commented 3 years ago

Problem

This repo doesn't produce llvm / rust executables for Windows.

Solution

Add a build job in GitHub referencing the future version 1.16 in the Rust repo, and also add support for building Windows in build.sh.

Important note: clang-12 is not produced by the Windows build, so I removed it in the build artifacts produced. Since clang is already at version 12, I thought this would be OK. If you prefer, I can add a specific build step to copy clang to clang-12 in Windows.

Also, because of a path being too long on Windows, the copy portion from rust/build has changed to specify the exact places to copy from.

dmakarov commented 3 years ago

Jon, the changes look good to me. Let's just make sure that the build works on Windows CI agents. It looks like the windows agents don't have wget available, so maybe that need to be installed or some other utility used? The build on each of the three platforms our automated way to make new binary releases.

joncinque commented 3 years ago

@dmakarov I totally missed that, apologies! I'll switch it to use curl -O since that's available on windows. How does that sound?

dmakarov commented 3 years ago

no worries. sounds good!

joncinque commented 3 years ago

I don't have write permissions on the repo unfortunately, so you'll have to merge this in 😅 thanks for the quick review!