search

anza-xyz / solana-pay

A new standard for decentralized payments.
https://solanapay.com
Apache License 2.0
1.31k stars 461 forks source link

Update README.md #114

Closed flodef closed 2 years ago

flodef commented 2 years ago

Change the app opening adress as it was displaying solana pay logo, instead of the real app.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

solana-pay – ./point-of-sale

🔍 Inspect: https://vercel.com/solana-labs/solana-pay/GrdJ4UE5xcd4jhpoDHw8ZnwscQTx
✅ Preview: https://solana-pay-git-fork-flodef-patch-1-solana-labs.vercel.app

solana-pay-docs – ./docs

🔍 Inspect: https://vercel.com/solana-labs/solana-pay-docs/BQ84Pmk2nHWJefWiBmseCWJFefM3
✅ Preview: https://solana-pay-docs-git-fork-flodef-patch-1-solana-labs.vercel.app

jordaaash commented 2 years ago

This is by design. It will redirect to /new if valid query params are provided. Check your label and recipient query params to make sure they are correct.

flodef commented 2 years ago

You're right, just tested, it worked ! I find it a bit confusing anyway. Thanks for the quick answer. And keep up the good work.

jordaaash commented 2 years ago

Here's where we check for the params: https://github.com/solana-labs/solana-pay/blob/fb40bfc0a3a43824a4657b3d2a0ba67d3867c09f/point-of-sale/src/components/routes/RootRoute.tsx#L26-L42

Here's where we do the redirect: https://github.com/solana-labs/solana-pay/blob/fb40bfc0a3a43824a4657b3d2a0ba67d3867c09f/point-of-sale/src/components/Router.tsx#L15-L28

The redirect will only occur if the params are provided, and especially if the recipient is a valid pubkey.

flodef commented 2 years ago

I see. That sure helps a lot !! Thank you :-D