search

anza-xyz / solana-pay

A new standard for decentralized payments.
https://solanapay.com
Apache License 2.0
1.29k stars 450 forks source link

Replaced BaseURL by window.location #159

Closed flodef closed 1 year ago

flodef commented 1 year ago

When using "navigate" after payment has been processed, the BaseURL is reset and it ends up to navigating to default location (which is set to "localhost" in App.ts).

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solana-pay ❌ Failed (Inspect) Dec 12, 2022 at 10:19PM (UTC)
solana-pay-docs ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 10:19PM (UTC)
flodef commented 1 year ago

@jordansexton What about this PR ? Is there something to add or could it be commited ?

jordaaash commented 1 year ago

With this change, do we need baseURL as a config anymore? Can we replace other uses of it the same way?

flodef commented 1 year ago

With this change, do we need baseURL as a config anymore? Can we replace other uses of it the same way?

Totally agree! Thanks a lot for this remark. As previously, didn't get far enough into refactorisation.