search

anza-xyz / solana-pay

A new standard for decentralized payments.
https://solanapay.com
Apache License 2.0
1.29k stars 450 forks source link

BackButton style proposal #176

Closed flodef closed 1 year ago

flodef commented 1 year ago

BackButton should be hidden when disabled + take less space for mobile phone with small resolution

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
solana-pay ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 0:58AM (UTC)
solana-pay-docs ✅ Ready (Inspect) Visit Preview Dec 12, 2022 at 0:58AM (UTC)
jordaaash commented 1 year ago

This app is meant as an example and proof of concept only. I'm hesitant to change the styles here, and time is limited to test these changes.

flodef commented 1 year ago

This app is meant as an example and proof of concept only. I'm hesitant to change the styles here, and time is limited to test these changes.

I just understood from what you said that the Point of Sale is just a "Proof of Concept". Nevertheless, why do you keep motivated people from trying to improve it? From what I see, you seem an excellent developer, but are lacking the time to take care of it, bring ideas, and update. When I took your "Proof of Concept" to use in real life with everyday users, I had a lot of bugs to correct and features to add. I would have love to share this with the community and avoir other dev to waste time on the same problems I got.

"Open source" means you let the community build around the project and on the project. But it seems you are the only one building this POS !! If you scared about dev breaking things, why don't you create a special branch and let someone else take care of it ?

Decaf is using a custom version of your "Proof of Concept" and is selling it to shops. However, not every shop can afford to buy a Decaf custom POS licence. Is your goal to onboard the next billion people on Solana ?? Then let dev build on top of your "Proof of Concept" and propose open source POS to shops that can't afford a Decaf licence and just want to try Solana. Crypto definitely need tools to help lambda users access it. Point of sale and wallet are what people are using everyday! Please, don't let it stay as a "Proof of Concept", it would be such a waste.

If you decide to keep your project as a "Proof of Concept", fair enough, I won't spend any more of your time and mine sending PR. . Thanks a lot for sharing.

steveluscher commented 1 year ago

Hey @flodef. The code in examples/point-of-sale is what's called a ‘reference implementation.’ Reference implementations are demonstrations of a specification – in this case Solana Pay – in action. They're generally not meant to be deployed in production as-is, but rather to act as a reference for others.

Changes to the reference implementation that relate to its correctness or adherence to the Solana Pay specification are in scope, and changes that affect the aesthetics or usability of the example app itself are out of scope.

You should for sure fork the reference implementation and open source something targeted toward the exact user you've described though! You could be a huge part of onboarding that next billion through the creation of something free, fast, and delightful to use. We created and open sourced the Solana Pay spec to encourage exactly that.

Thank you for your contributions 🚀

flodef commented 1 year ago

Always happy to read from you. Thanks a lot for the precisions. As I strongly suggested to Jordan, it could be wise to precise the scope of PR and the purpose of it directly in the README.md from "examples/point-of-sale" (it went from "point-of-sale" to "examples/point-of-sale" very recently).

Like you saw on Twitter, I've already forked the reference implementation and it's live. Sharing it from solana-labs' repository for dev to start building from a prod version instead of reference implementation could save other devs a lot of time. It's working out of the box, and you just have to change settings in vercel. You don't even have to be a dev to use / customise it.

But, in the current state, that's not gonna happen. No Solana dev will come to flodef's github repository to start a Point of Sale based on Solana Pay. Like me, they'll come on solana-labs', find the reference implementation and start building from it, wasting time, instead of improving each other's work. In the end, every dev is building its own point-of-sale implementation in its small corner...