search

anza-xyz / solana-pay

A new standard for decentralized payments.
https://solanapay.com
Apache License 2.0
1.29k stars 450 forks source link

Add Gradient to QR code options #186

Closed flodef closed 1 year ago

flodef commented 1 year ago

Allows to put some color with Gradient in your QR code.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
solana-pay ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 6:15PM (UTC)
solana-pay-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 6:15PM (UTC)
mcintyre94 commented 1 year ago

Thanks again @flodef but we're not going to merge this. The underlying library @solana/qr-code-styling has a lot of options, and it's intentionally very easy to create your own Options object and create a QR code using any of these options. We're not going to expand this API which is only intended to provide the basic options and try to push people toward easily scanned QR codes by default.

flodef commented 1 year ago

Adding an optional Gradient option doesn't complicate anything but only add one more option to power users who need more, while keeping it as simple as before for previous users. So creating a QR code is still as simple as it was ! I don't get your point, but that's OK, if you took the decision to not merge, I'll kindly comply. PS: I updated the file with your suggestion about adding it to createQROptions :-)