Open mcintyre94 opened 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated |
---|---|---|---|---|
solana-pay | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 28, 2023 at 4:32PM (UTC) |
solana-pay-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add your feedback | Feb 28, 2023 at 4:32PM (UTC) |
Marking as draft because we'll want to coordinate this release so we don't confuse application developers. Maybe a 1.1 or alpha branch?
This PR adds the spec changes to support the proposed/alpha 1.1 spec
MessageSignRequestURLFields
is added with just alink
field. InternallyencodeURL
encodes it in the same way as a transaction requestNotes:
label
andmessage
fields ofTransactionRequestURLFields
? They're not in the spec and I haven't included them in the fields for message signing requests. I think they're superseded bylabel
in the GET response, andmessage
in the POST response. If we eventually remove them we could simplify the encoding since transaction request and message signing request would be the same structure.encodeTransactionOrMessageSignRequestURL
is kinda hacky, but we can't differentiateTransactionRequestURLFields
fromMessageSignRequestURLFields
at a typescript level