anza-xyz / validator-lab

Deploy and test your new Agave validator features in a kubernetes-based cluster
https://www.anza.xyz/
7 stars 4 forks source link

Enable specific features via cli for solana-genesis #45

Open gregcusack opened 5 months ago

gregcusack commented 5 months ago

v1.17 and v1.18 are incompatable with cluster_type == Development. All features are enabled by default. Specifically the feature timely_vote_credits in v1.17 is incompatable with v1.18. In fact, timely_vote_credits should not be turned on in v1.17 at all.

One way to fix this is to comment out the timely_vote_credits feature in (sdk/src/feature_set.rs)[https://github.com/anza-xyz/agave/blob/master/sdk/src/feature_set.rs#L822-L1020]. But the is cumbersome and doesn't allow much flexibility. Plus other developers have complained that enabling and disabling features to check compatibility between versions is a pain and time consuming. So we need a way to 1) enable all features by default (already exists) 2) pass in a set of features that should be activated, leaving all other features inactive 3) pass in a set of features that should not be activated, leaving all other features active

This probably has to be done in agave repo.....